-
Notifications
You must be signed in to change notification settings - Fork 908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(subp): Measure subprocess command time #4606
Conversation
Didn't implement this in the same log that subp currently emits since it is useful to see that log before the command is run, for debugging in case cloud-init crashes or hangs. |
Hello! Thank you for this proposed change to cloud-init. This pull request is now marked as stale as it has not seen any activity in 14 days. If no activity occurs within the next 7 days, this pull request will automatically close. If you are waiting for code review and you are seeing this message, apologies! Please reply, tagging TheRealFalcon, and he will ensure that someone takes a look soon. (If the pull request is closed and you would like to continue working on it, please do tag TheRealFalcon to reopen it.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This results in a ton of logs like this:
2023-12-01 03:32:20,754 - subp.py[DEBUG]: command ['hostname', 'me'] took 0.0s to run
and also adds a fair amount of extra logs.
I think we should either change %.3s
to %.5s
, or only log if the time elapsed is >= .1
a3f7084
to
b087341
Compare
Hmm, that serves no one.
I prefer this way to avoid the extra logs. |
b087341
to
7d4e658
Compare
Rebased to resolve conflict with main. |
@smoser's idea